Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write unit tests #3

Closed
jverkoey opened this issue Dec 3, 2016 · 2 comments
Closed

Write unit tests #3

jverkoey opened this issue Dec 3, 2016 · 2 comments
Labels
Tests
Milestone
v1.0.0

Comments

@jverkoey
Copy link

jverkoey commented Dec 3, 2016

No description provided.

@jverkoey jverkoey added the Tests label Dec 3, 2016
@jverkoey jverkoey modified the milestone: v1.0.0 Dec 3, 2016
@appsforartists
Copy link
Member

appsforartists commented Dec 3, 2016 •
edited
Loading

Test ideas:

  1. Can unsubscribe be called only once per subscription?
  2. What happens if you have a chain of streams and call unsubscribe/subscribe/unsubscribe/subscribe?
    • Does this match the behavior of xstream and rx?
  3. Does the creator have to return an unsubscribe?
  4. Do two observers to a synchronous creator each receive the value?

@appsforartists
Copy link
Member

🎊 My diff is ready for review at http://codereview.cc/D2214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@jverkoey @appsforartists