Skip to content
This repository has been archived by the owner on Aug 13, 2021. It is now read-only.

Resolve Xcode 9 build failures #123

Merged
merged 3 commits into from
Oct 31, 2017
Merged

Resolve Xcode 9 build failures #123

merged 3 commits into from
Oct 31, 2017

Conversation

jverkoey
Copy link
Contributor

@jverkoey jverkoey commented Oct 26, 2017

Type aliases in Swift only allow us to indicate that T conforms to a single type, so in order to specify that our spring T conforms to Zeroable and Subtractable we introduced a composite type, ZeroableAndSubtractable. Prior to Swift 3.2 conforming to Zeroable and Subtractable appeared sufficient to meet the check for conforming to ZeroableAndSubtractable. With Swift 3.2 it appears this is no longer sufficient, so we need to declare explicit conformity to ZeroableAndSubtractable where applicable.

Copy link

@romoore romoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a commit message body to explain how merging the Zeroable and Subtractable types will eliminate Xcode 9 failures?

@@ -0,0 +1,30 @@
/*
Copyright 2016-present The Material Motion Authors. All Rights Reserved.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the copyright to 2017.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jverkoey
Copy link
Contributor Author

Done.

Copy link

@romoore romoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jverkoey jverkoey merged commit fae8c59 into develop Oct 31, 2017
@jverkoey jverkoey deleted the xcode9 branch October 31, 2017 17:52
@benSmith1981
Copy link

Is this updated in the pod file? I get these errors if I instlal with the pod still

huangboju pushed a commit to huangboju/material-motion-swift that referenced this pull request Feb 3, 2020
* Xcode 9 build failure fixes.

* Add comment.

* Update copyright year.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants