-
Notifications
You must be signed in to change notification settings - Fork 79
Resolve Xcode 9 build failures #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide a commit message body to explain how merging the Zeroable and Subtractable types will eliminate Xcode 9 failures?
@@ -0,0 +1,30 @@ | |||
/* | |||
Copyright 2016-present The Material Motion Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the copyright to 2017.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is this updated in the pod file? I get these errors if I instlal with the pod still |
* Xcode 9 build failure fixes. * Add comment. * Update copyright year.
Type aliases in Swift only allow us to indicate that
T
conforms to a single type, so in order to specify that our springT
conforms toZeroable
andSubtractable
we introduced a composite type,ZeroableAndSubtractable
. Prior to Swift 3.2 conforming toZeroable
andSubtractable
appeared sufficient to meet the check for conforming toZeroableAndSubtractable
. With Swift 3.2 it appears this is no longer sufficient, so we need to declare explicit conformity toZeroableAndSubtractable
where applicable.