Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Update bazel workspace to latest versions. #120

Merged
merged 4 commits into from
Dec 7, 2018
Merged

Update bazel workspace to latest versions. #120

merged 4 commits into from
Dec 7, 2018

Conversation

jverkoey
Copy link
Contributor

@jverkoey jverkoey commented Dec 6, 2018

This increases the following versions:

Tested by running:

./.kokoro

This increases the following versions:

- bazel from 0.11 to 0.20.0
- build_bazel_rules_apple from 7ea0557 to 0.9.0
- build_bazel_rules_swift to 0.4.0 (new)
- bazel_ios_warnings from v1.0.1 to v2.0.0
- Xcode from 8 to 9.
- Swift pinned to 3.
- Unit test upgraded to UI tests.

Tested by running:

    ./.kokoro
@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #120 into develop will increase coverage by 1.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #120      +/-   ##
===========================================
+ Coverage    86.59%   87.92%   +1.33%     
===========================================
  Files           26        9      -17     
  Lines         2558      613    -1945     
  Branches       163        0     -163     
===========================================
- Hits          2215      539    -1676     
+ Misses         329       74     -255     
+ Partials        14        0      -14
Impacted Files Coverage Δ
src/MDMMotionAnimator.m 86.63% <0%> (-1.67%) ⬇️
tests/unit/MotionAnimatorTests.swift
tests/unit/UIKitBehavioralTests.swift
tests/unit/NonAdditiveAnimatorTests.swift
tests/unit/AnimationRemovalTests.swift
tests/unit/InstantAnimationTests.swift
tests/unit/UIKitEquivalencyTests.swift
tests/unit/ImplicitAnimationTests.swift
tests/unit/QuartzCoreBehavioralTests.swift
tests/unit/MotionAnimatorTests.m
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c805783...0b6b863. Read the comment docs.

Copy link
Contributor

@romoore romoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR summary to document the .kokoro script refactoring changes as well.

.kokoro Show resolved Hide resolved
.kokoro Outdated Show resolved Hide resolved
.kokoro Outdated Show resolved Hide resolved
.kokoro Outdated Show resolved Hide resolved
.kokoro Outdated Show resolved Hide resolved
.kokoro Outdated Show resolved Hide resolved
@jverkoey jverkoey merged commit e28f79e into develop Dec 7, 2018
@jverkoey jverkoey deleted the bump branch December 7, 2018 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants