Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Testing Great Again #64

Open
pingpongboss opened this issue Nov 4, 2016 · 2 comments
Open

Make Testing Great Again #64

pingpongboss opened this issue Nov 4, 2016 · 2 comments
Labels

Comments

@pingpongboss
Copy link
Contributor

Currently, testing Material Motion often involves defining one-shot Plans and Performers in test code. This is a ton of boilerplate.

The reason we have to do this is often because we want to verify a side-effect of the performer, but we cannot have a direct reference to it due to the loose Plan/Performer coupling.

To close this issue, we must have a framework in place for testing to be painless. No more creating Plan/Performer classes if possible.

@pingpongboss
Copy link
Contributor Author

We might want to consider putting util classes like StepChoreographer into a separate package other than com.google.android.material.motion.runtime to visually separate it from the actual unit tests.

http://codereview.cc/D1868#38122

@pingpongboss
Copy link
Contributor Author

All *Tests should be renamed *Test. Context: http://codereview.cc/D2174#inline-8392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant