Set status icons to at least 16px #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I dunno. It looks kinda weird with a wide panel and tiny icons. |
How wide are we talking? Is there a use-case to go above 48? I don't have a HiDPI monitor to test,I though it was like in the browsers where the px unit is relative. This PR doesn't change previous behavior at panel-size 48. |
jntesteves
force-pushed
the
feature/restore-status-icons-sizes
branch
from
46ca775
to
ccc23b0
Compare
jntesteves
changed the title
|
I changed it to be at least 16px, but scale larger on panel sizes above 48. I'm still not convinced this is necessary, but it doesn't hurt anyway. I only want to fix the icons being currently too small at PS 32. |
|
@HalfVoxel you have the final word on this one 😁 |
HalfVoxel
approved these changes
Oct 5, 2022
|
Perfect thanks you guys ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No reason to be dynamic when the clock and other text are not. 16px always looks good and is readable. It was getting too small at panel-size 32, where it was 16px before ae2b52e and bb6742a.