Rework of search panel with gnome 43 source code #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalfVoxel
requested changes
Oct 4, 2022
| for (const providerDisplay of this.providerDisplayMap.values()) { | ||
| providerDisplay.updateSearch([], []); | ||
| } | ||
| //this.remove_all_children(); |
There was a problem hiding this comment.
This is a reset code not debug but I can add a comment and remove the commented code
| @@ -349,123 +349,6 @@ declare module 'ui' { | |||
| } | |||
| } | |||
|
|
|||
| export namespace appDisplay { | |||
There was a problem hiding this comment.
Why remove these? The typings are still correct, even if we are not using them anymore.
There was a problem hiding this comment.
Well most of them aren't valid anymore and since the class now exist on our side I felt it was pointless
Well it's should be ! If you are still on gnome 42 It's would be nice for you to try it |
HalfVoxel
requested changes
Oct 5, 2022
| for (let prop in rawMeta) { | ||
| // we can use the serialized icon variant directly | ||
| if (prop !== 'icon') | ||
| unpackedMeta[prop] = metas[i][prop].deepUnpack(); |
There was a problem hiding this comment.
Suggested change
| unpackedMeta[prop] = metas[i][prop].deepUnpack(); | |
| unpackedMeta[prop] = rawMeta[prop].deepUnpack(); |
| const rawMeta = metas[i]; | ||
| const unpackedMeta: UnpackedMeta = {}; | ||
| for (let prop in rawMeta) { | ||
| // we can use the serialized icon variant directly |
HalfVoxel
approved these changes
Oct 5, 2022
|
Good job! |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since in gnome 43 they changed a lot of code we used for search features I had issues with typings and compatibility so I decided to copy the new gnome 43 source code and add types for it and rework our current search code to use it so previous gnome 43 Material Shell user will get benefit from it.
So following files
are almost basic copy past & typed from gnome-shell source code