Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to blind fix 922 from logs #923

Merged
merged 7 commits into from Dec 16, 2022
Merged

Try to blind fix 922 from logs #923

merged 7 commits into from Dec 16, 2022

Conversation

PapyElGringo
Copy link
Collaborator

@PapyElGringo PapyElGringo commented Dec 14, 2022

While inspecting the logs it's seem that while creating a new window the placeholder find a way to activate himself which isn't wanted.

From my investigation it's could be related to a ghost stage event and therefore I enforce the need of a proper click to activate it (Mouse down + mouse up)

EDIT: 16/12/22
After updating my system I face the proper issue which seem to be related to a change in transition behavior of Clutter.Actor.
It's seem that when an actor is reparented it's drop all current transition and therefore create a bug in MS.
I fixed it by completing the animation when the animation is interrupted.

I also fixed and unrelated issue in our interval code

src/extension.ts Outdated Show resolved Hide resolved
src/layout/msWorkspace/msWindow.ts Outdated Show resolved Hide resolved
src/utils/async.ts Show resolved Hide resolved
src/widget/translationAnimator.ts Outdated Show resolved Hide resolved
src/widget/translationAnimator.ts Outdated Show resolved Hide resolved
src/widget/translationAnimator.ts Outdated Show resolved Hide resolved
src/widget/translationAnimator.ts Show resolved Hide resolved
src/widget/translationAnimator.ts Outdated Show resolved Hide resolved
@PapyElGringo PapyElGringo merged commit b96ad20 into main Dec 16, 2022
@PapyElGringo PapyElGringo deleted the blind-fix-922 branch December 16, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants