fix: prevent enter to save for invalid row

material-table-core · Nov 1, 2021 · 905d525 · 905d525
1 parent 849fdc6
commit 905d525
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/components/MTableEditRow/index.js b/src/components/MTableEditRow/index.js
@@ -135,8 +135,15 @@ function MTableEditRow(props) {
       });
     return mapArr;
   }
+  const isValid = props.columns.every((column) => {
+    const error = validateInput(column, state.data);
+    return error.isValid;
+  });
 
   const handleSave = () => {
+    if (!isValid) {
+      return;
+    }
     const newData = state.data;
     delete newData.tableData;
     props.onEditingApproved(props.mode, state.data, props.data);
@@ -152,10 +159,6 @@ function MTableEditRow(props) {
       ...MTableEditRow.defaultProps.localization,
       ...props.localization
     };
-    const isValid = props.columns.every((column) => {
-      const error = validateInput(column, state.data);
-      return error.isValid;
-    });
     const actions = [
       {
         icon: props.icons.Check,