fi: keep tabledata from previous columns

material-table-core · Jun 27, 2021 · e0fa5ee · e0fa5ee
1 parent 93063db
commit e0fa5ee
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/src/material-table.js b/src/material-table.js
@@ -69,7 +69,7 @@ export default class MaterialTable extends React.Component {
     );
   }
 
-  setDataManagerFields(props, isInit) {
+  setDataManagerFields(props, isInit, prevColumns) {
     let defaultSortColumnIndex = -1;
     let defaultSortDirection = '';
     if (props && props.options.sorting !== false) {
@@ -82,7 +82,7 @@ export default class MaterialTable extends React.Component {
           : '';
     }
 
-    this.dataManager.setColumns(props.columns);
+    this.dataManager.setColumns(props.columns, prevColumns);
     this.dataManager.setDefaultExpanded(props.options.defaultExpanded);
     this.dataManager.changeRowEditing();
 
@@ -145,7 +145,7 @@ export default class MaterialTable extends React.Component {
 
     if (propsChanged) {
       const props = this.getProps(this.props);
-      this.setDataManagerFields(props);
+      this.setDataManagerFields(props, false, this.props.columns);
       this.setState(this.dataManager.getRenderState());
     }
 
@@ -164,7 +164,7 @@ export default class MaterialTable extends React.Component {
     }
   }
 
-  getProps(props) {
+  getProps(props, prevColumns) {
     const calculatedProps = { ...(props || this.props) };
     calculatedProps.components = {
       ...MaterialTable.defaultProps.components,
@@ -1068,7 +1068,7 @@ export default class MaterialTable extends React.Component {
                             top: 0,
                             right: 0,
                             boxShadow: '-2px 0px 15px rgba(125,147,178,.25)',
-                            overflowX: 'hidden',
+                            overflowX: 'clip',
                             zIndex: 11
                           }}
                         >

diff --git a/src/utils/data-manager.js b/src/utils/data-manager.js
@@ -62,7 +62,7 @@ export default class DataManager {
     this.filtered = false;
   }
 
-  setColumns(columns) {
+  setColumns(columns, prevColumns = []) {
     let usedWidth = ['0px'];
 
     this.columns = columns.map((columnDef, index) => {
@@ -78,7 +78,7 @@ export default class DataManager {
       ) {
         usedWidth.push(width);
       }
-
+      const prevColumn = prevColumns.find(({ id }) => id === index);
       const tableData = {
         columnOrder: index,
         filterValue: columnDef.defaultFilter,
@@ -87,11 +87,12 @@ export default class DataManager {
         width,
         initialWidth: width,
         additionalWidth: 0,
+        ...(prevColumn ? prevColumn.tableData : {}),
         ...columnDef.tableData,
         id: index
       };
-
-      return { ...columnDef, tableData };
+      columnDef.tableData = tableData;
+      return columnDef;
     });
     const undefinedWidthColumns = this.columns.filter((c) => {
       if (c.hidden) {