Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table tree/sorting/... state is lost every time a Dialog is open from a clickable cell #51

Closed
koutto opened this issue Jan 12, 2021 · 7 comments
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@koutto
Copy link

koutto commented Jan 12, 2021

Hello all,
Thanks for keeping this project alive !
I am using latest version of @material-table/core.
I have a table with custom rendering in a column, that displays a clickable icon. Every time it is clicked, a state is changed to open a Dialog.
However, everytime it is done, the state of the table is lost, i.e. if any column sortering has been set up, it is lost. Similarly, I am also using tree data, and if some rows have been expanded, everything is collapsed like in initial state.

Do you have any idea of how to avoid this behaviour and keep the current table state ?

@koutto koutto added the question Further information is requested label Jan 12, 2021
@oze4 oze4 added the duplicate This issue or pull request already exists label Jan 12, 2021
@oze4 oze4 self-assigned this Jan 12, 2021
@oze4
Copy link
Member

oze4 commented Jan 12, 2021

Hello! Hopefully this will be fixed today. There is currently another issue open #48 where we pinpointed the root cause.

We will be putting all updates on #48 so I'm going to close this one out.

Thanks for bringing this to our attention! We apologize for the inconvenience.

@oze4 oze4 closed this as completed Jan 12, 2021
@oze4
Copy link
Member

oze4 commented Jan 12, 2021

@Domino987 another issue in regards to the table losing state. Looks like it's related to #48

@Domino987
Copy link
Contributor

Domino987 commented Jan 12, 2021

@oze4 Probably yes. This might cause it. The change was introduced to respond to changes to the default prop changes, like initial page etc. If we remove this, these changes of the prop during the lifecycle of the table will be ignored. Maybe we can think of a way to get around it. To both respond to the changes but not lose State

@oze4
Copy link
Member

oze4 commented Jan 12, 2021

Sounds good to me. In that case I will reopen this issue.

@oze4 oze4 reopened this Jan 12, 2021
@jok3r-framework
Copy link

Ok thanks a lot for your awesome work for keeping this project up-to-date.
Cheers guys

@oze4
Copy link
Member

oze4 commented Jan 12, 2021

@Domino987 so this was introduced in case someone wants to start on page 2 (or 5 or 103 or whatever) vs page 1? I'm not sure I follow entirely.

@oze4 oze4 added bug Something isn't working and removed question Further information is requested labels Jan 13, 2021
@oze4
Copy link
Member

oze4 commented Jan 14, 2021

All updates will be on #59

Closing.

@oze4 oze4 closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants