Fix crash changing from a larger page size to a smaller one #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using remote data loading with paging and you reduce the the rows per page (from 20 to 15), the app will crash because it will try to render 20 items at a row page size of 15 before data is loaded and `emptyRowCount` will be `-5` which crashes when trying to do `Array(-5)`
Domino987
approved these changes
Nov 12, 2021
|
Would it be possible for you to add a test to cover this use case as well? |
I am not familiar with creating tests here, but I can try, mostly it's mocking remote loading and changing page size to a lower value. I want to say that after making this change my app didn't crash anymore. |
|
Yes and I will merge it. You could copy one of the tests files and mock the data call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Haven't found an issue in this repo yet.
Description
When using remote data loading with paging and you reduce the the rows per page (from 20 to 15), the app will crash because it will try to render 20 items at a row page size of 15 before data is loaded and
emptyRowCountwill be-5which crashes when trying to doArray(-5)Impacted Areas in Application
List general components of the application that this PR will affect:
Fixed a possible crash when changing page size.
Additional Notes
This is a bug fix.