Use local Paging when is not remote data #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#662
Description
Updated to use local paging when is not remote data, currently if you pass page and totalCount, code not does paging, and if dev takes care page outside the package breaks sorting, due to the material package detects new data, and refresh but if you have enabled sorting, never show the next page data.
Here is a link to the issue on a code sandbox
Related PRs
List related PRs against other branches: None
Impacted Areas in Application
List general components of the application that this PR will affect:
src/material-table.js
Additional Notes
Here is a link to the issue on a code sandbox