fix: add string array to columns.field prop types #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for passing an array to the 'field' attribute of a column was previously added to allow the selection of keys with full-stops. Although the the type of the field was updated in the type declaration file, 'prop-types.js' was not updated to reflect these changes, resulting in runtime errors.
Domino987
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #767
Description
Support for passing an array to the
fieldattribute of a column was previously added to allow the selection of keys with full-stops. Although the the type of the field was updated in the type declaration file,prop-types.jswas not updated to reflect these changes, resulting in runtime errors.Related PRs
List related PRs against other branches:
Impacted Areas in Application
List general components of the application that this PR will affect:
columns.field.