Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature) Allow custom hide columns action #833

Conversation

EmilianoMorghen
Copy link
Contributor

Dear Team,

First and foremost, I want to express my heartfelt gratitude for the incredible work each of you has contributed. Over the past year, I've had the pleasure of utilizing this package, and I must say, I've thoroughly enjoyed it.

TL;DR
I'm in need of overwriting the default 'hide column' action.

Description

Upon delving into how custom actions are rendered and handled, I've observed that they lack access to crucial data such as columns and event callbacks like onColumnsChanged or onSearchChanged. Providing access to this data would empower users to customize the behavior of default actions.

Impacted Areas in Application

List general components of the application that this PR will affect:

  • MTableToolbar
  • MTableActions
  • MTableAction

Additional Notes

There are multiple approaches to implementing the overwrite of default actions' behavior, and I am open to hearing your insights on the matter.

I am eager to tackle this task with your expert guidance and oversight, ensuring that we maintain the highest quality standards that you consistently uphold.

@EmilianoMorghen EmilianoMorghen marked this pull request as ready for review February 28, 2024 11:20
@EmilianoMorghen EmilianoMorghen changed the title (wip) (feature) Allow custom hide columns action (feature) Allow custom hide columns action Mar 12, 2024
Copy link
Contributor

@Domino987 Domino987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and should be a good addition, one minor change it is good to go. Thank you

src/components/MTableToolbar/index.js Outdated Show resolved Hide resolved
@Domino987 Domino987 merged commit b489dc9 into material-table-core:master Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants