Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on parseISO import from date-fns v3.x. (Fixes #838) #840

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

TheWeirdDev
Copy link
Contributor

Related Issue

Description

date-fns v3.x has a slightly different import syntax which causes material-table to crash when it tries to import parseISO.
This problem makes the date and datetime fields unusable.

This PR fixes it by using the correct import syntax according to this comment.

Related PRs

  • None

Impacted Areas in Application

  • Any MTableCell with date or datetime type

Additional Notes

Demos:

@TheWeirdDev TheWeirdDev requested a review from oze4 as a code owner April 25, 2024 07:55
@Domino987
Copy link
Contributor

Thanks, I'll merge it Thursday.

@Domino987 Domino987 merged commit 5408b45 into material-table-core:master Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants