Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observations between community and official #1286

Closed
Tatsh opened this issue Dec 3, 2023 · 2 comments
Closed

Observations between community and official #1286

Tatsh opened this issue Dec 3, 2023 · 2 comments

Comments

@Tatsh
Copy link

Tatsh commented Dec 3, 2023

Since many of us are coming from the community version, I think many would like to see some of the features of the community version incorporated here somehow. This is comparing Dark High Contrast. In general, I think there is way too much yellow colour on screen where there used to be white in the community version.

  • There is no distinction between the type and the type's type argument. Also can be considered that there is no difference between certain imports and actually built-in keywords like str, int, etc. I do not think imports should ever be the same colour of as a keyword regardless of origin or prevalence.

    image

    Community:

    image

    • This also makes exceptions catch the attention too much:

      image

      Community:

      image

  • Some imports are coloured blue, others are highlighted yellow as if to be an official keyword. Some are highlighted white.

    image

    Community made them all white:

    image

  • A change I do welcome is not having red arguments (but I do not like having Path and str being the same colour, see point 1):

    image

    Community:

    image

@Tatsh
Copy link
Author

Tatsh commented Dec 3, 2023

The lack of distinctions seem to be caused by the Pylance server or similar (it marks any class as the same type as str (also technically a class)). Once the server is going, it marks the types and the styles apply. I can say this did not happen in the Community Material version.

@Tatsh
Copy link
Author

Tatsh commented Dec 3, 2023

I was able to get most of what I wanted with these overrides:

  "editor.semanticTokenColorCustomizations": {
    "enabled": true,
    "rules": {
      "*.builtin": "#B2CCD6",
      "module": "#fff"
    }
  },
  "editor.tokenColorCustomizations": {
    "textMateRules": [
      {
        "scope": [
          "keyword.control",
          "markup.quote",
          "variable.parameter",
          "variable.parameter.function.language.special.self.python"
        ],
        "settings": {
          "fontStyle": ""
        }
      }
    ]
  },

@Tatsh Tatsh closed this as completed Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant