Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix js not updating when doing npm run dev #280

Merged
merged 1 commit into from Oct 18, 2022

Conversation

Smankusors
Copy link
Member

Proposed changes

This should fix where the js didn't update when you run the npm run dev. To validate this, just add an alert(1) in one of the js files, and the alert should popup. If you remove the alert, it shouldn't popup anymore.

Screenshots (if appropriate) or codepen:

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Smankusors Smankusors added the meta Issues with the project itself or our GitHub repository. label Sep 21, 2022
@Smankusors Smankusors requested a review from a team September 21, 2022 17:25
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but LGTM

@wuda-io
Copy link
Member

wuda-io commented Oct 18, 2022

I am testing it now...

@wuda-io wuda-io merged commit e344d62 into materializecss:main Oct 18, 2022
@wuda-io
Copy link
Member

wuda-io commented Oct 18, 2022

Should I add the Hacktoberfest Label? 🥨🎃
Sorry, I am new to handling this PR merging stuff. Please correct me if I did something wrong.
Nevertheless best greets fellows!

@Smankusors
Copy link
Member Author

yeah thanks for reviewing this 😁

I didn't thought about Hacktoberfest on this PR though... but I think we should add the hacktoberfest-accepted label for every merged PRs this month 😉

@DanielRuf
Copy link

I don't think we need the label for the merged PRs.

See https://hacktoberfest.com/participation/#maintainers

Merged PRs normally count.

@wuda-io wuda-io added the hacktoberfest-accepted The PR is a valuable contribution that counts for the Hacktoberfest Event label Oct 18, 2022
@wuda-io
Copy link
Member

wuda-io commented Oct 18, 2022

Ok, thanks for the Info. Anyhow I added it for completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted The PR is a valuable contribution that counts for the Hacktoberfest Event meta Issues with the project itself or our GitHub repository.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants