Fix js not updating when doing npm run dev#280
Merged
Conversation
Member
|
I am testing it now... |
Member
|
Should I add the Hacktoberfest Label? 🥨🎃 |
Member
Author
|
yeah thanks for reviewing this 😁 I didn't thought about Hacktoberfest on this PR though... but I think we should add the |
|
I don't think we need the label for the merged PRs. See https://hacktoberfest.com/participation/#maintainers Merged PRs normally count. |
Member
|
Ok, thanks for the Info. Anyhow I added it for completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This should fix where the js didn't update when you run the
npm run dev. To validate this, just add an alert(1) in one of the js files, and the alert should popup. If you remove the alert, it shouldn't popup anymore.Screenshots (if appropriate) or codepen:
n/a
Types of changes
Checklist: