Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metastore: topological sort #22

Closed
benesch opened this issue Apr 2, 2019 · 1 comment
Closed

metastore: topological sort #22

benesch opened this issue Apr 2, 2019 · 1 comment

Comments

@benesch
Copy link
Member

benesch commented Apr 2, 2019

Metastore can cause a crash on reboot by presenting dataflows in the "wrong" order, i.e., an order that is not topologically sorted by dependencies.
@benesch
Copy link
Member Author

benesch commented Apr 3, 2019

Fixed in 3287bc5.

@benesch benesch closed this as completed Apr 3, 2019
quodlibetor pushed a commit to quodlibetor/materialize that referenced this issue Mar 3, 2020
@flavray
Schema documentation and unit tests. (MaterializeInc#22)
d6e9c79 
* Remove RecordSchema struct

This makes `Schema::Record` more in line with the other `Schema::`
variants (`Enum` and `Fixed`).

Also makes creation of `Schema::Record` easier (less `Rc`, one less
struct) and allows to use only specific items (e.g: `fields`).

* Add documentation and tests to Schema

* Avoid borrowing Schema in types::Record

This is a not-so-great trick that will hopefully not be needed once MaterializeInc#19
has been tackled.

* Add documentation for Record

* Add module-level documentation for schema.rs and types.rs

* Add docstrings for parse_*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benesch