Merge pull request #2 from materialr/fix/close-behaviour

fix: close behaviour now more consistent

src/index.jsx

@@ -20,6 +20,7 @@ class Dialog extends React.Component {
     this.focusTrap = undefined;
     this.root = undefined;
     this.surface = undefined;
+    this.dialogFoundationClose = this.dialogFoundationClose.bind(this);
     this.dialogFoundationCreate = this.dialogFoundationCreate.bind(this);
     this.dialogFoundationDestroy = this.dialogFoundationDestroy.bind(this);
     this.dialogFoundationOpen = this.dialogFoundationOpen.bind(this);
@@ -43,7 +44,7 @@ class Dialog extends React.Component {
       this.dialogFoundationOpen();
     }
     if (!visible && wasVisible) {
-      this.dialogFoundationDestroy();
+      this.dialogFoundationClose();
     }
   }
   componentWillUnmount() {
@@ -68,6 +69,9 @@ class Dialog extends React.Component {
       'mdc-dialog--theme-dark': this.props.dark,
     });
   }
+  dialogFoundationClose() {
+    this.dialogFoundation.close();
+  }
   dialogFoundationCreate() {
     const { onAccept, onCancel } = this.props;
     this.dialogFoundation = dialogFoundation({

src/index.test.jsx

@@ -122,13 +122,13 @@ test('Dialog > Opens when the \'visible\' prop becomes \'true\'', () => {
 });
 
 test('Dialog > Closes when the \'visible\' prop becomes \'false\'', () => {
-  const destroy = jest.fn();
+  const close = jest.fn();
   const wrapper = mount(<Dialog {...defaultProps} visible />);
-  wrapper.instance().dialogFoundation.destroy = destroy;
+  wrapper.instance().dialogFoundation.close = close;
   wrapper.setProps({ visible: false });
   const expected = 1;
 
-  const actual = destroy.mock.calls.length;
+  const actual = close.mock.calls.length;
 
   expect(actual).toBe(expected);
 });
@@ -148,7 +148,7 @@ test('Dialog > Closes when the component unmounts', () => {
 test('Dialog > Removes the foundation after destroying', () => {
   const wrapper = mount(<Dialog {...defaultProps} visible />);
   const expected = undefined;
-  wrapper.setProps({ visible: false });
+  wrapper.instance().dialogFoundationDestroy();
 
   const actual = wrapper.instance().dialogFoundation;