-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dataSink and dataSource API. #17
Implement dataSink and dataSource API. #17
Conversation
b48c3f1
to
7e4a29f
Compare
Should be compatible with the OpenStack SWIFT object storage API.
035d8f9
to
8aafc68
Compare
@yoavnash @pablo-de-andres This is my proposal for the dataSink and dataSource API. It is based on the OpenStack SWIFT API which is largely compatible with S3 for core functions. I only specified operations for the purpose of MarketPlace that appeared most important to me. Finally, you may notice that some functions have "optional path parameters". To my knowledge neither FastAPI nor Flask support optional path parameters since they conceptually represent different endpoints. However, you can associate |
In addition to the above, it seems that capabilities for querying ( |
Co-authored-by: nash <62147380+yoavnash@users.noreply.github.com>
for more information, see https://pre-commit.ci
I don't plan to drop anything. I am just introducing the objectStorage API here. Capabilities for querying can be added later. |
@yoavnash @pablo-de-andres As discussed, I will implement the container-level API. After I'm done I will re-request your review. |
@yoavnash @pablo-de-andres Ready for another review iteration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. I think that looks very good.
Implements all dataSink and dataSource-related operations in compliance with the OpenStack Swift object storage API on the container level. That means the operations for creating, replacing, and deleting datasets (objects) are in compliance with the API specified by Swift and it is assumed that one dataSink/dataSource is equivalent to a object storage container.