Improve modularity #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be merged after #22 . |
Base automatically changed from
fix/create-or-replace-dataset-metadata-operation-path
to
main
June 23, 2022 08:51
csadorf
force-pushed
the
improve-modularity
branch
from
2e77ba8
to
6b212c5
Compare
pablo-de-andres
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set groups common operations (e.g. those belonging to a transformation app) into a dedicated module and router. This massively improves the modularity of the package and will make it easier to use it as basis for the implementation of an app.
Please note that the changes to the openapi.json file only concern the order of the listed responses. I consolidated common responses between and within routers which means that more specialized responses, i.e., those present only for a specific router or a specific response are included later into the openapi.json file. This does not have any effect on the actual specification and does not affect the swagger view at all.