Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Test package build during standard CI workflow. #31

Merged
merged 2 commits into from
Jul 4, 2022
Merged

CI: Test package build during standard CI workflow. #31

merged 2 commits into from
Jul 4, 2022

Conversation

csadorf
Copy link
Collaborator

@csadorf csadorf commented Jul 4, 2022

No description provided.

@csadorf
Copy link
Collaborator Author

csadorf commented Jul 4, 2022

@pablo-de-andres This will test that the package can actually be built as part of the standard CI workflow so that the release workflow is less likely to fail. It did require to remove the api instance from the root module to use dynamic attributes for the description and version which should not be an issue IMO.

@csadorf csadorf marked this pull request as ready for review July 4, 2022 12:53
@csadorf csadorf enabled auto-merge (squash) July 4, 2022 12:55
@csadorf csadorf merged commit 74da900 into main Jul 4, 2022
@csadorf csadorf deleted the ci/test-build-package branch July 4, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablo-de-andres pablo-de-andres pablo-de-andres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@csadorf @pablo-de-andres