Reaxpro work service #56
Conversation
|
I thought we discussed using one unique endpoint for uploading data, and a potential parameter to flag wether it is cache or persistent? |
|
I need to discuss with Matthias about this. In his implementation he doesn't have a collection and also he is using uuid as a unique parameter. I have to suggest the name change to dataset_name instead. |
| class NewModel(BaseModel): | ||
| parameters: dict | ||
|
|
||
| modelname: NewTransformationStates = TransformationState.CREATED |
There was a problem hiding this comment.
Why do you need a new model? Can yo unot use the NewTransformationModel? And why is the modelname a state?
There was a problem hiding this comment.
Sorry, I should have removed this. This class is not used.
| async def get_transformation_state( | ||
| transformation_id: TransformationId, | ||
| ) -> TransformationStateResponse: | ||
| async def get_transformation_state() -> TransformationStateResponse: |
There was a problem hiding this comment.
How are you supposed to get the state if you do not provide an id for the transformation?
There was a problem hiding this comment.
This is a mistake. I was not intended to remove it. I will add it again.
|
If you can review those two minor changes, I would merge this to main, and move to review materials-marketplace/python-sdk#70 |
Co-authored-by: Pablo de Andres <9430234+pablo-de-andres@users.noreply.github.com>
Co-authored-by: Pablo de Andres <9430234+pablo-de-andres@users.noreply.github.com>
for more information, see https://pre-commit.ci
Changes for addtional endpoints required by reaxpro-workflow.