Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elec dev #230

Merged
merged 7 commits into from Mar 25, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/mp_api/electrodes/models.py
Expand Up @@ -86,25 +86,27 @@ class InsertionElectrodeDoc(InsertionVoltageStep):
battery_id: str = Field(None, description="The id for this battery document.")

framework_formula: str = Field(
None, description="The id for this battery document."
None, description="The chemical formula without the working ion."
)

host_structure: Structure = Field(
None, description="Host structure (structure without the working ion)",
)

adj_pairs: List[InsertionVoltageStep] = Field(
None, description="Returns all the Voltage Steps",
None,
description="Returns all the Voltage Steps",
)

working_ion: Element = Field(
None, description="The working ion as an Element object",
None,
description="The working ion as an Element object",
)

num_steps: float = Field(
num_steps: int = Field(
None,
description="The number of distinct voltage steps in from fully charge to "
"discharge based on the stable intermediate states",
"discharge based on the stable intermediate states",
)

max_voltage_step: float = Field(
Expand Down