Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] MPRester updates #303

Merged
merged 81 commits into from Jul 1, 2021
Merged

[WIP] MPRester updates #303

merged 81 commits into from Jul 1, 2021

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jun 24, 2021

This PR contains updates to MPRester convenience functions for materials, thermo and electronic structure data.

@munrojm munrojm changed the title MPRester updates [WIP] MPRester updates Jun 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021

Codecov Report

Merging #303 (a5a6ca6) into main (0bbefea) will increase coverage by 41.27%.
The diff coverage is 64.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #303       +/-   ##
===========================================
+ Coverage   32.39%   73.67%   +41.27%     
===========================================
  Files         109       59       -50     
  Lines        3084     1937     -1147     
===========================================
+ Hits          999     1427      +428     
+ Misses       2085      510     -1575     
Impacted Files Coverage Δ
src/mp_api/routes/_consumer/client.py 0.00% <0.00%> (ø)
src/mp_api/routes/dielectric/client.py 37.50% <0.00%> (-7.50%) ⬇️
src/mp_api/routes/elasticity/client.py 30.30% <0.00%> (-4.18%) ⬇️
src/mp_api/routes/electrodes/client.py 41.66% <0.00%> (-8.34%) ⬇️
src/mp_api/routes/eos/client.py 45.00% <0.00%> (-11.25%) ⬇️
src/mp_api/routes/magnetism/client.py 34.48% <0.00%> (-5.52%) ⬇️
src/mp_api/routes/molecules/client.py 32.25% <0.00%> (-7.03%) ⬇️
src/mp_api/routes/piezo/client.py 45.45% <0.00%> (-10.11%) ⬇️
src/mp_api/routes/surface_properties/client.py 37.03% <0.00%> (-6.45%) ⬇️
src/mp_api/routes/synthesis/data_adaptor.py 0.00% <0.00%> (ø)
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ff5f69...a5a6ca6. Read the comment docs.

@munrojm munrojm merged commit 3e19048 into main Jul 1, 2021
@munrojm munrojm deleted the mprester_update branch July 1, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants