Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint updates #326

Merged
merged 11 commits into from
Jul 8, 2021
Merged

Endpoint updates #326

merged 11 commits into from
Jul 8, 2021

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jul 7, 2021

This PR contains:

  • Update MPRester with more explicit methods and tests
  • Overhaul phonon endpoint
  • Disable appropriate tests when no API key in environment
  • Enable bare Monty encoded response for most endpoints

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021

Codecov Report

Merging #326 (c278b23) into main (428f1dd) will increase coverage by 0.35%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   89.09%   89.45%   +0.35%     
==========================================
  Files          59       59              
  Lines        1917     1916       -1     
==========================================
+ Hits         1708     1714       +6     
+ Misses        209      202       -7     
Impacted Files Coverage Δ
src/mp_api/routes/charge_density/client.py 94.11% <83.33%> (-2.32%) ⬇️
src/mp_api/matproj.py 97.58% <100.00%> (+3.87%) ⬆️
src/mp_api/routes/__init__.py 100.00% <100.00%> (ø)
src/mp_api/routes/phonon/client.py 100.00% <100.00%> (ø)
src/mp_api/routes/phonon/query_operators.py 0.00% <0.00%> (-100.00%) ⬇️
src/mp_api/routes/electrodes/client.py 91.66% <0.00%> (+4.16%) ⬆️
src/mp_api/routes/materials/utils.py 100.00% <0.00%> (+25.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 428f1dd...c278b23. Read the comment docs.

@munrojm munrojm merged commit 959dedc into main Jul 8, 2021
@munrojm munrojm deleted the endpoint_updates branch July 8, 2021 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants