optional flag to return task doc with chgcar #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For materials with no valid charge density task_id like `mp-1104953` the current version gets an empty list at line 756 then errors out at the sorting step. This change should fix that. Also, I think it makes sense to return `None` here since we are not guaranteeing every single charge density.
Codecov Report
@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 92.56% 92.74% +0.17%
==========================================
Files 63 63
Lines 2032 2039 +7
==========================================
+ Hits 1881 1891 +10
+ Misses 151 148 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.