Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint schemes added to materials and summary #446

Merged
merged 4 commits into from
Nov 30, 2021
Merged

Hint schemes added to materials and summary #446

merged 4 commits into from
Nov 30, 2021

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Nov 30, 2021

This PR adds hints to the materials and summary endpoints using the new HintScheme class in Maggma.

@munrojm munrojm added the release:minor Minor release bump label Nov 30, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #446 (3e451c7) into main (a5214e9) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   93.35%   93.58%   +0.23%     
==========================================
  Files          65       67       +2     
  Lines        2152     2167      +15     
==========================================
+ Hits         2009     2028      +19     
+ Misses        143      139       -4     
Impacted Files Coverage Δ
src/mp_api/core/client.py 90.40% <ø> (ø)
src/mp_api/client.py 95.61% <100.00%> (+0.05%) ⬆️
src/mp_api/routes/materials/hint_scheme.py 100.00% <100.00%> (ø)
src/mp_api/routes/summary/hint_scheme.py 100.00% <100.00%> (ø)
src/mp_api/routes/thermo/client.py 96.77% <100.00%> (ø)
src/mp_api/routes/bonds/client.py 95.83% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f31191a...3e451c7. Read the comment docs.

@munrojm munrojm merged commit c94800f into main Nov 30, 2021
@munrojm munrojm deleted the hint_support branch November 30, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Minor release bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants