Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch hint schemes #447

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Patch hint schemes #447

merged 3 commits into from
Dec 1, 2021

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Dec 1, 2021

Patch hint schemes to default to returning an empty dictionary for the store argument.

@munrojm munrojm added the release:patch Patch release label Dec 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #447 (4a32f10) into main (2fb5a95) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
- Coverage   93.58%   93.49%   -0.09%     
==========================================
  Files          67       67              
  Lines        2167     2169       +2     
==========================================
  Hits         2028     2028              
- Misses        139      141       +2     
Impacted Files Coverage Δ
src/mp_api/routes/materials/hint_scheme.py 83.33% <0.00%> (-16.67%) ⬇️
src/mp_api/routes/summary/hint_scheme.py 87.50% <0.00%> (-12.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fb5a95...4a32f10. Read the comment docs.

@munrojm munrojm merged commit 0075208 into main Dec 1, 2021
@munrojm munrojm deleted the patch_hints branch December 1, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants