Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move server side code to emmet-api package and parallel requests #475

Merged
merged 53 commits into from Jan 28, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jan 6, 2022

This PR moves all server side API code to the new emmet-api package. It also implements parallel requests for select query parameters, including those involved in data pagination.

@munrojm munrojm added the release:minor Minor release bump label Jan 6, 2022
@munrojm munrojm changed the title Move server side code to emmet-api package Move server side code to emmet-api package and parallel requests Jan 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #475 (3e693cd) into main (ed581fd) will increase coverage by 0.18%.
The diff coverage is 91.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
+ Coverage   93.12%   93.31%   +0.18%     
==========================================
  Files          68       34      -34     
  Lines        2227     1271     -956     
==========================================
- Hits         2074     1186     -888     
+ Misses        153       85      -68     
Impacted Files Coverage Δ
src/mp_api/__init__.py 100.00% <ø> (+9.09%) ⬆️
src/mp_api/routes/bonds.py 95.83% <ø> (ø)
src/mp_api/routes/electrodes.py 96.42% <ø> (ø)
src/mp_api/routes/magnetism.py 96.29% <ø> (ø)
src/mp_api/routes/oxidation_states.py 100.00% <ø> (ø)
src/mp_api/routes/piezo.py 93.75% <ø> (ø)
src/mp_api/routes/provenance.py 100.00% <ø> (ø)
src/mp_api/routes/charge_density.py 92.59% <66.66%> (ø)
src/mp_api/core/client.py 89.89% <86.80%> (-0.51%) ⬇️
src/mp_api/routes/robocrys.py 92.30% <92.30%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2796143...3e693cd. Read the comment docs.

@munrojm munrojm self-assigned this Jan 27, 2022
@munrojm munrojm merged commit 667848e into main Jan 28, 2022
@munrojm munrojm deleted the emmet_api branch February 22, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Minor release bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants