Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance parallel requests and bug fixes #496

Merged
merged 10 commits into from Jan 31, 2022
Merged

Enhance parallel requests and bug fixes #496

merged 10 commits into from Jan 31, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jan 30, 2022

This PR expands the use of threadpools for parallel requests. It also fixes some pagination bugs with some user requested values of num_chunks and chunk_size.

@munrojm munrojm added the release:minor Minor release bump label Jan 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2022

Codecov Report

Merging #496 (a86db9d) into main (667848e) will decrease coverage by 0.58%.
The diff coverage is 97.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
- Coverage   93.31%   92.72%   -0.59%     
==========================================
  Files          34       34              
  Lines        1271     1306      +35     
==========================================
+ Hits         1186     1211      +25     
- Misses         85       95      +10     
Impacted Files Coverage Δ
src/mp_api/routes/robocrys.py 92.30% <ø> (ø)
src/mp_api/routes/synthesis.py 94.11% <ø> (ø)
src/mp_api/core/client.py 90.96% <97.46%> (+1.07%) ⬆️
src/mp_api/__init__.py 100.00% <100.00%> (ø)
src/mp_api/routes/materials.py 74.57% <0.00%> (-15.26%) ⬇️
src/mp_api/client.py 92.69% <0.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 667848e...a86db9d. Read the comment docs.

@munrojm munrojm merged commit 560706e into main Jan 31, 2022
@munrojm munrojm deleted the enhance_parallel branch February 22, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Minor release bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants