Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include response handling in multithreading #538

Merged
merged 6 commits into from Feb 25, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Feb 25, 2022

Previously, response handling for GET requests was not being included as part of the multi threading. This PR fixes that to speed up certain types of requests.

@munrojm munrojm added the release:minor Minor release bump label Feb 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #538 (5eac7ea) into main (eaae661) will decrease coverage by 0.11%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
- Coverage   92.58%   92.47%   -0.12%     
==========================================
  Files          34       34              
  Lines        1309     1315       +6     
==========================================
+ Hits         1212     1216       +4     
- Misses         97       99       +2     
Impacted Files Coverage Δ
src/mp_api/routes/electronic_structure.py 88.88% <66.66%> (-1.21%) ⬇️
src/mp_api/core/client.py 90.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaae661...5eac7ea. Read the comment docs.

@munrojm munrojm merged commit aeefde8 into main Feb 25, 2022
@munrojm munrojm deleted the enhancement/multithread_response_processing branch March 4, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Minor release bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants