Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prefixed query params #571

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Update prefixed query params #571

merged 3 commits into from
Apr 20, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Apr 13, 2022 •
edited
Loading

This PR updates pagination, sorting, and fields projection query parameters which are changed in materialsproject/maggma#620

It also renamed chunk and num_chunks to page and per_page to be commensurate with maggma pagination changes.

@munrojm munrojm added the release:minor Minor release bump label Apr 13, 2022
@munrojm munrojm removed the release:minor Minor release bump label Apr 20, 2022
@munrojm munrojm merged commit 1e96481 into main Apr 20, 2022
@munrojm munrojm deleted the enhancement/underscore_param_changes branch April 26, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@munrojm