Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsiged S3 configuration when using in deployment #583

Merged
merged 2 commits into from
Apr 24, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Apr 23, 2022

Make sure the boto session is not unsigned when using the client in an AWS deployment.

@munrojm munrojm added the release:patch Patch release label Apr 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2022

Codecov Report

Merging #583 (be81cab) into main (683ec9d) will increase coverage by 0.06%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
+ Coverage   92.11%   92.17%   +0.06%     
==========================================
  Files          34       34              
  Lines        1382     1380       -2     
==========================================
- Hits         1273     1272       -1     
+ Misses        109      108       -1     
Impacted Files Coverage Δ
src/mp_api/routes/charge_density.py 86.56% <50.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 683ec9d...be81cab. Read the comment docs.

@munrojm munrojm merged commit a4933b5 into main Apr 24, 2022
@munrojm munrojm deleted the bugfix/s3_config_class branch April 24, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants