Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client side checks on material and task IDs #589

Merged
merged 7 commits into from
Apr 26, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Apr 26, 2022

This PR adds formatting checks to all material_id and task_id values used in both single document and general search queries.

@munrojm munrojm added the release:patch Patch release label Apr 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2022

Codecov Report

Merging #589 (50aaedc) into main (a4933b5) will increase coverage by 0.01%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
+ Coverage   92.17%   92.18%   +0.01%     
==========================================
  Files          34       35       +1     
  Lines        1380     1395      +15     
==========================================
+ Hits         1272     1286      +14     
- Misses        108      109       +1     
Impacted Files Coverage Δ
src/mp_api/routes/charge_density.py 86.56% <33.33%> (ø)
src/mp_api/routes/xas.py 92.85% <50.00%> (+0.26%) ⬆️
src/mp_api/routes/summary.py 98.11% <75.00%> (+0.03%) ⬆️
src/mp_api/core/utils.py 87.50% <87.50%> (ø)
src/mp_api/core/client.py 91.15% <95.65%> (+0.08%) ⬆️
src/mp_api/client.py 91.66% <100.00%> (ø)
src/mp_api/routes/grain_boundary.py 97.14% <100.00%> (+0.08%) ⬆️
src/mp_api/routes/materials.py 74.57% <100.00%> (ø)
src/mp_api/routes/thermo.py 97.22% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4933b5...50aaedc. Read the comment docs.

@munrojm munrojm merged commit 89de344 into main Apr 26, 2022
@munrojm munrojm deleted the enhancememt/client_side_checks branch April 26, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants