Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update molecules doc import #598

Merged
merged 9 commits into from
May 11, 2022
Merged

Update molecules doc import #598

merged 9 commits into from
May 11, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented May 11, 2022

Fixes the document model import in the MoleculesRester

@munrojm munrojm added the release:patch Patch release label May 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #598 (b5f86f7) into main (a4933b5) will decrease coverage by 0.70%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
- Coverage   92.17%   91.46%   -0.71%     
==========================================
  Files          34       35       +1     
  Lines        1380     1395      +15     
==========================================
+ Hits         1272     1276       +4     
- Misses        108      119      +11     
Impacted Files Coverage Δ
src/mp_api/routes/molecules.py 93.10% <100.00%> (ø)
src/mp_api/routes/charge_density.py 79.10% <0.00%> (-7.47%) ⬇️
src/mp_api/client.py 89.77% <0.00%> (-1.90%) ⬇️
src/mp_api/routes/materials.py 74.57% <0.00%> (ø)
src/mp_api/core/utils.py 87.50% <0.00%> (ø)
src/mp_api/routes/summary.py 98.11% <0.00%> (+0.03%) ⬆️
src/mp_api/routes/thermo.py 97.22% <0.00%> (+0.07%) ⬆️
src/mp_api/core/client.py 91.15% <0.00%> (+0.08%) ⬆️
src/mp_api/routes/grain_boundary.py 97.14% <0.00%> (+0.08%) ⬆️
src/mp_api/routes/xas.py 92.85% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4933b5...b5f86f7. Read the comment docs.

@munrojm munrojm merged commit 6e4da02 into main May 11, 2022
@munrojm munrojm deleted the bugfix/molecules_rename branch May 31, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants