Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert missing comma in setup.py #697

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Conversation

sezelt
Copy link
Contributor

@sezelt sezelt commented Oct 21, 2022

There is a missing comma on line 36 of setup.py that causes "emmet-core[all]>=0.36.4" and "custodian" to be interpreted as one string.

This then corrupts the poetry.lock that gets generated for projects that depend on mp-api, e.g.

[[package]]
name = "mp-api"
version = "0.29.2"
description = "API Server for the Materials Project"
category = "main"
optional = false
python-versions = ">=3.8"

[package.dependencies]
emmet-core = ">=0.36.4"
monty = ">=2021.3.12"
msgpack = "*"
pymatgen = ">=2022.3.7"
requests = ">=2.23.0"
typing-extensions = ">=3.7.4.1"

[package.extras]
all = ["boto3", "emmet-core[all] (>=0.36.4custodian)", "mpcontribs-client"]

yields

[...]
Installing dependencies from lock file

Could not parse version constraint: >=0.36.4custodian

There is a missing comma on line 36 of `setup.py` that causes `"emmet-core[all]>=0.36.4"` and `"custodian"` to be interpreted as one string.
@munrojm
Copy link
Member

munrojm commented Oct 21, 2022

Thank you @sezelt!

@munrojm munrojm merged commit ebe7c43 into materialsproject:main Oct 21, 2022
@sezelt sezelt deleted the patch-1 branch October 21, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants