Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix charge density task_ids list query #707

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Nov 14, 2022

Fixes a bug where task_id list queries were not getting formatted properly for the charge density related methods.

@munrojm munrojm added the release:patch Patch release label Nov 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Base: 81.18% // Head: 81.23% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (5cb5e66) compared to base (17dd2cc).
Patch coverage: 57.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
+ Coverage   81.18%   81.23%   +0.04%     
==========================================
  Files          36       36              
  Lines        1733     1737       +4     
==========================================
+ Hits         1407     1411       +4     
  Misses        326      326              
Impacted Files Coverage Δ
mp_api/client/routes/charge_density.py 67.16% <57.14%> (+2.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit 574cda5 into main Nov 14, 2022
@munrojm munrojm deleted the bugfix/charge_density_task_ids branch November 14, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants