Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep boto3 optional #836

Merged
merged 11 commits into from Aug 15, 2023
Merged

Keep boto3 optional #836

merged 11 commits into from Aug 15, 2023

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Aug 15, 2023

This PR ensures boto3 remains an optional dependency.

@munrojm munrojm added the release:patch Patch release label Aug 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Patch coverage: 41.80% and project coverage change: -10.21% ⚠️

Comparison is base (3ffecd2) 79.85% compared to head (6fc721c) 69.64%.
Report is 26 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #836       +/-   ##
===========================================
- Coverage   79.85%   69.64%   -10.21%     
===========================================
  Files          38       51       +13     
  Lines        1881     2418      +537     
===========================================
+ Hits         1502     1684      +182     
- Misses        379      734      +355     
Files Changed Coverage Δ
mp_api/client/routes/_user_settings.py 100.00% <ø> (ø)
mp_api/client/routes/materials/absorption.py 32.25% <ø> (ø)
mp_api/client/routes/materials/alloys.py 52.63% <ø> (ø)
mp_api/client/routes/materials/bonds.py 93.33% <ø> (ø)
mp_api/client/routes/materials/chemenv.py 85.10% <ø> (ø)
mp_api/client/routes/materials/dielectric.py 92.85% <ø> (ø)
mp_api/client/routes/materials/doi.py 100.00% <ø> (ø)
mp_api/client/routes/materials/elasticity.py 96.77% <ø> (ø)
mp_api/client/routes/materials/electrodes.py 91.30% <ø> (ø)
mp_api/client/routes/materials/eos.py 94.73% <ø> (ø)
... and 37 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit 5f15be1 into main Aug 15, 2023
11 checks passed
@munrojm munrojm deleted the bugfix/optional_boto3 branch August 30, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants