Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy loading and caching #842

Merged
merged 25 commits into from Sep 11, 2023
Merged

Lazy loading and caching #842

merged 25 commits into from Sep 11, 2023

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Sep 11, 2023

Adds lazy loading of resters alongside some caching to greatly speed up instantiation of MPRester.

@munrojm munrojm added the release:minor Minor release bump label Sep 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Patch coverage: 91.66% and project coverage change: +0.45% 🎉

Comparison is base (7109a44) 69.90% compared to head (40464e1) 70.36%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   69.90%   70.36%   +0.45%     
==========================================
  Files          51       51              
  Lines        2429     2480      +51     
==========================================
+ Hits         1698     1745      +47     
- Misses        731      735       +4     
Files Changed Coverage Δ
mp_api/client/routes/materials/__init__.py 88.23% <ø> (-0.34%) ⬇️
mp_api/client/mprester.py 65.74% <87.50%> (+0.68%) ⬆️
mp_api/client/routes/materials/materials.py 77.66% <96.96%> (+9.09%) ⬆️
mp_api/client/core/client.py 82.79% <100.00%> (ø)
mp_api/client/core/utils.py 61.81% <100.00%> (+1.44%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit 63adcdf into main Sep 11, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Minor release bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants