Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pydantic deserialization issues with root obj #854

Merged
merged 2 commits into from Oct 11, 2023

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Oct 11, 2023

This PR converts pydantic deserialization calls to use dict(model) instead of model.model_dump() to avoid some edge cases with root level instantiated python objects being partially de-serialized.

Note this is not an issue in pydantic v1.

@munrojm munrojm added the release:patch Patch release label Oct 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (83b27a0) 70.42% compared to head (cafa16a) 70.42%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #854   +/-   ##
=======================================
  Coverage   70.42%   70.42%           
=======================================
  Files          51       51           
  Lines        2482     2482           
=======================================
  Hits         1748     1748           
  Misses        734      734           
Files Coverage Δ
mp_api/client/core/client.py 82.87% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit 47fc608 into main Oct 11, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants