Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow settings not correctly updated in the documentation #169

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

JaGeo
Copy link
Member

@JaGeo JaGeo commented Sep 14, 2022

Summary

By accident, I recently also had this error in my code. I think it originated from this part of the documentation. It's correct in the first example but not here. update_user_kpoints_settings will return a new flow and it would get lost in this way.

@JaGeo JaGeo changed the title Flow missing in documentation Flow not correctly updated in the documentation Sep 14, 2022
@JaGeo JaGeo changed the title Flow not correctly updated in the documentation Flow settings not correctly updated in the documentation Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #169 (adcc3b8) into main (4dbeccb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   74.99%   74.99%           
=======================================
  Files          52       52           
  Lines        4675     4675           
  Branches      736      736           
=======================================
  Hits         3506     3506           
  Misses        983      983           
  Partials      186      186           

@utf
Copy link
Member

utf commented Sep 14, 2022

Sorry about that!

@utf utf merged commit 25a2a74 into materialsproject:main Sep 14, 2022
@JaGeo
Copy link
Member Author

JaGeo commented Sep 14, 2022

Thanks. And no worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants