Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix powerups in docs #17

Merged
merged 2 commits into from
Nov 27, 2021
Merged

Fix powerups in docs #17

merged 2 commits into from
Nov 27, 2021

Conversation

Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented Nov 27, 2021

In the docs, the powerups aren't actually applied because they are not done in-place. I've fixed this in the PR (and fixed the formatting in the rest of the .rst).

Apologies that I keep having to go back to fix linting errors. For some reason, I am getting the error below when I try to do any commits, and I haven't figured out why.

Check Yaml...........................................(no files to check)Skipped
Fix python encoding pragma...........................(no files to check)Skipped
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
autoflake............................................(no files to check)Skipped
black................................................(no files to check)Skipped
blacken-docs.............................................................Passed
isort (python).......................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
type annotations not comments........................(no files to check)Skipped
rst ``code`` is two backticks............................................Passed
rst directives end with two colons.......................................Passed
rst ``inline code`` next to normal text..................................Passed
mypy.................................................(no files to check)Skipped
error: cannot spawn null: Exec format error
error: gpg failed to sign the data
fatal: failed to write commit object

Not modified in-place
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2021

Codecov Report

Merging #17 (2b9e972) into main (9c9d863) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   67.65%   67.65%           
=======================================
  Files          41       41           
  Lines        3370     3370           
  Branches      445      490   +45     
=======================================
  Hits         2280     2280           
  Misses        955      955           
  Partials      135      135           

@utf
Copy link
Member

utf commented Nov 27, 2021

Fantastic! I made that change (previously modifications were performed in place) but forgot to update the documentation.

@utf utf merged commit 7352c31 into materialsproject:main Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants