Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lso dos of lobster being not saved in schema #279

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

naik-aakash
Copy link
Contributor

Summary

Schema update
Issue - LSO DOSCAR from lobster did not get added due to a missing file extension
Fix - update the schema to fix this issue

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #279 (3cc00a6) into main (161f685) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
- Coverage   65.89%   65.73%   -0.16%     
==========================================
  Files          73       73              
  Lines        7039     7039              
  Branches      897      897              
==========================================
- Hits         4638     4627      -11     
- Misses       2137     2149      +12     
+ Partials      264      263       -1     
Impacted Files Coverage Δ
src/atomate2/lobster/schemas.py 92.82% <100.00%> (ø)

... and 1 file with indirect coverage changes

@naik-aakash
Copy link
Contributor Author

Hi @utf , Can you please merge this PR. It is one minor change in the code. Thank you for the help 😄

@utf
Copy link
Member

utf commented Mar 24, 2023

Thanks!

@utf utf merged commit 61fe712 into materialsproject:main Mar 24, 2023
@utf utf added the fix Bug fix PR label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants