Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix _get_strong_bonds function #289

Merged

Conversation

naik-aakash
Copy link
Contributor

Strongest bonds for ICOBI and ICOBI were incorrect

  • Fixes introduced in the associated _get_strong_bonds function in schema.

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #289 (05a0088) into main (ed6a81e) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
- Coverage   65.89%   65.75%   -0.15%     
==========================================
  Files          73       73              
  Lines        7040     7043       +3     
  Branches      897      898       +1     
==========================================
- Hits         4639     4631       -8     
- Misses       2137     2149      +12     
+ Partials      264      263       -1     
Impacted Files Coverage Δ
src/atomate2/lobster/schemas.py 92.94% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

@JaGeo
Copy link
Member

JaGeo commented Mar 28, 2023

Thanks @naik-aakash for fixing the issue.

@utf
Copy link
Member

utf commented Mar 28, 2023

Great. Thank you.

@utf utf merged commit 8b7835f into materialsproject:main Mar 28, 2023
@naik-aakash
Copy link
Contributor Author

You are welcome 😄

@utf utf added the fix Bug fix PR label Sep 1, 2023
@naik-aakash naik-aakash deleted the fix_get_strong_bonds_lobster_schema branch June 20, 2024 06:59
@naik-aakash naik-aakash restored the fix_get_strong_bonds_lobster_schema branch June 20, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants