Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More ruff #344

Merged
merged 8 commits into from
May 23, 2023
Merged

More ruff #344

merged 8 commits into from
May 23, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented May 19, 2023

Mostly unexciting changes. I left on TODO: there are currently 3 tests that use pytest.raises() to that only check the error type. These are flagged by ruff as too broad (recommendation is to also check the error message). I ignored these lints but would be better to add match="expected err msg".

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #344 (970a760) into main (b4a87a3) will decrease coverage by 0.06%.
The diff coverage is 28.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
- Coverage   65.73%   65.67%   -0.06%     
==========================================
  Files          72       72              
  Lines        7018     7007      -11     
  Branches      896      896              
==========================================
- Hits         4613     4602      -11     
  Misses       2138     2138              
  Partials      267      267              
Impacted Files Coverage Δ
src/atomate2/amset/schemas.py 0.00% <0.00%> (ø)
src/atomate2/cp2k/run.py 53.33% <0.00%> (ø)
src/atomate2/cp2k/sets/base.py 63.84% <0.00%> (ø)
src/atomate2/lobster/run.py 55.55% <0.00%> (ø)
src/atomate2/vasp/jobs/amset.py 0.00% <ø> (ø)
src/atomate2/vasp/run.py 44.26% <0.00%> (ø)
src/atomate2/vasp/schemas/calc_types/_generate.py 0.00% <ø> (ø)
src/atomate2/vasp/schemas/calc_types/enums.py 0.00% <0.00%> (ø)
src/atomate2/vasp/schemas/calc_types/utils.py 0.00% <0.00%> (ø)
src/atomate2/vasp/sets/core.py 83.95% <0.00%> (ø)
... and 12 more

@utf utf merged commit 9133651 into main May 23, 2023
3 of 6 checks passed
@utf
Copy link
Member

utf commented May 23, 2023

Thanks!

@janosh janosh deleted the more-ruff branch June 2, 2023 18:27
@utf utf added enhancement Improvements to existing features house-keeping Formatting and code quality tweaks and removed enhancement Improvements to existing features labels Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
house-keeping Formatting and code quality tweaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants