Remove VASP calc types schema #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mjwen are you able to resolve the conflicts for this PR? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
==========================================
+ Coverage 65.69% 74.82% +9.13%
==========================================
Files 78 74 -4
Lines 7479 6551 -928
Branches 970 947 -23
==========================================
- Hits 4913 4902 -11
+ Misses 2263 1347 -916
+ Partials 303 302 -1 |
|
@utf done. |
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that we use emmet vasp scheme as done in #269, the calc types schema is no longer needed. Stuff in calc types previously in atomate2 but not in emmet has been migrated into emmet.
Need to wait for materialsproject/emmet#764 and a new emmet-core release before merging.