Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Defects WF #430

Merged
merged 18 commits into from
Aug 14, 2023
Merged

Update to Defects WF #430

merged 18 commits into from
Aug 14, 2023

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Jul 10, 2023

Selective dynamics and perturbation for Defects WF

  • Allow selective dynamics (clamp atoms away from defect center)
  • Allow perturbation of unclamped atoms

@JaGeo
Copy link
Member

JaGeo commented Jul 10, 2023

You might have seen my comment: it would also be great to add more infos on the workflows to the documentation. 😃

#396 (comment)

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #430 (fcb4c91) into main (402b5c0) will decrease coverage by 0.06%.
The diff coverage is 88.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   65.63%   65.57%   -0.06%     
==========================================
  Files          78       78              
  Lines        7437     7462      +25     
  Branches      961      964       +3     
==========================================
+ Hits         4881     4893      +12     
- Misses       2255     2267      +12     
- Partials      301      302       +1     
Files Changed Coverage Δ
src/atomate2/vasp/flows/defect.py 77.46% <ø> (ø)
src/atomate2/common/flows/defect.py 81.33% <66.66%> (-0.76%) ⬇️
src/atomate2/common/jobs/defect.py 85.71% <100.00%> (+2.22%) ⬆️

... and 1 file with indirect coverage changes

@utf
Copy link
Member

utf commented Aug 14, 2023

Thanks @jmmshn

@utf utf marked this pull request as ready for review August 14, 2023 11:02
@utf utf merged commit e7e2992 into materialsproject:main Aug 14, 2023
7 checks passed
@utf utf added the enhancement Improvements to existing features label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants