Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clearer documentation on lobster worker #440

Merged
merged 6 commits into from
Jul 28, 2023

Conversation

JaGeo
Copy link
Member

@JaGeo JaGeo commented Jul 19, 2023

I added more specific documentation for the Lobster worker. It should now be quite easy to experienced fireworks users to adapt to the Lobster workflow.

As this is a tiny change:
@janosh or @utf

Thanks!

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #440 (3ab73e8) into main (b64125b) will increase coverage by 0.07%.
The diff coverage is 90.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   64.85%   64.93%   +0.07%     
==========================================
  Files          74       74              
  Lines        7187     7209      +22     
  Branches      945      950       +5     
==========================================
+ Hits         4661     4681      +20     
  Misses       2228     2228              
- Partials      298      300       +2     
Impacted Files Coverage Δ
src/atomate2/lobster/schemas.py 92.74% <90.90%> (-0.17%) ⬇️

@JaGeo
Copy link
Member Author

JaGeo commented Jul 28, 2023

This would be ready for review as well.

@janosh
Copy link
Member

janosh commented Jul 28, 2023

Thanks @JaGeo!

@janosh janosh merged commit 59fd0b4 into materialsproject:main Jul 28, 2023
4 of 6 checks passed
@janosh janosh added the docs Improvements or additions to documentation label Jul 28, 2023
@JaGeo
Copy link
Member Author

JaGeo commented Jul 28, 2023

Thanks, @janosh . A tiny issue in the linting was somehow introduced. Tests on main are now failing, I think.

@janosh
Copy link
Member

janosh commented Jul 28, 2023

No worries, fixed in 24eaac4.

@JaGeo JaGeo deleted the lobster_parallelization_docu branch July 29, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants