Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub's deploy-pages action to deploy docs #475

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

janosh
Copy link
Member

@janosh janosh commented Aug 14, 2023

Closes #454.

TODO (if any)

Needs a test run to make sure it works.

@janosh janosh added docs Improvements or additions to documentation ci labels Aug 14, 2023
@utf
Copy link
Member

utf commented Aug 14, 2023

Thanks! Let's give it a whirl.

@utf utf merged commit d8415a5 into main Aug 14, 2023
5 checks passed
@janosh janosh deleted the 1st-party-gh-pages-action branch August 14, 2023 14:17
@utf
Copy link
Member

utf commented Aug 14, 2023

@janosh
Copy link
Member Author

janosh commented Aug 14, 2023

Oh right, one thing missing was to actually use the new action (which I just did):

Screenshot 2023-08-14 at 8 53 16 AM

Another thing that might be needed is to allow deploying from "All branches" regardless of branch protections (which I don't have access to). The relevant settings are here:

Screenshot 2023-08-14 at 8 54 57 AM

@utf
Copy link
Member

utf commented Aug 14, 2023

Great, thanks @janosh. I didn't have to change the branch protections. It seems like everything is working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to 1st party GH Pages Deploy action
2 participants